Remove network from CardanoDbBeacon
#2110
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WARNING: this change invalidate hashes of certificate that with signed entity type of type `CardanoImmutableFilesFull`, the `recompute-certificates-hash` command must be run on aggregators in order to keep their certificate chain valid.
This allow, by cascade, to remove the `network` of signer & aggregator epoch services.
by covering all cases (epoch + 1 > epoch was missing) and epoch priority over immutable file number.
Alenar
force-pushed
the
djo/1957/remove_network_from_cardano_db_beacon
branch
from
2cae308 to
5860e91
Compare
jpraynaud
reviewed
Nov 14, 2024
Alenar
force-pushed
the
djo/1957/remove_network_from_cardano_db_beacon
branch
from
5860e91 to
5a424cb
Compare
* mithril-persistence from `0.2.33` to `0.2.34` * mithril-aggregator from `0.5.110` to `0.5.111` * mithril-client-cli from `0.10.2` to `0.10.3` * mithril-common from `0.4.86` to `0.4.87` * mithril-signer from `0.2.212` to `0.2.213` * mithril-end-to-end from `0.4.48` to `0.4.49`
Alenar
force-pushed
the
djo/1957/remove_network_from_cardano_db_beacon
branch
from
54bb930 to
1dfedf1
Compare
Alenar
temporarily deployed
to
testing-preview
GitHub Actions
Inactive
Alenar
temporarily deployed
to
testing-sanchonet
GitHub Actions
Inactive
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Content
Warning
This PR changes the certificate hashes computation when their signed entity type is
CardanoImmutableFilesFull, therecompute-certificates-hashtool must be run in order to avoid breaking the chain.This PR remove the
networkfield from theCardanoDbBeaconstruct. With the groundwork done in #2097 no additional adaptation was needed.With this field removal some tools and services that used it only to produce
CardanoDbBeaconwere simplified:Pre-submit checklist
Comments
Some network field still persist in serialized
CardanoDbBeaconin database:open_message.beacon: existing network won't matter as they won't be mapped when read and since open messages are pruned regularly they will disappear by themself.certificate.beacon: existing network won't matter as they won't be mapped when read, plus certificate hashes will be recomputed for all certificates that hold aCardanoDbBeaconmeaning that all those certificates will be re-inserted in DB, eliminating the old network field.signed_entity.beacon: for previously storedCardanoImmutableFilesFullentities the network will remain but should not matter as it won't be read when de-serialized.signed_entity.artifact: for previously storedCardanoImmutableFilesFullentities the artifact anetworkfield will remain in serializedSnapshot, this should not matter as it won't be read when de-serialized.signed_beacon.beacon: existing network won't matter as they won't be mapped when read and since signed beacon are pruned regularly they will disappear by themself.Question: Should the database be cleaned of those remaining data with a migration ? Especially for signed_entities as those data won't be removed.
Issue(s)
Closes #1957